Merged origin/master into master

sails/src/api/controllers/SupervisorController.js

@@ -151,20 +151,25 @@ module.exports = {
 	// adds a new supervisor into the database
 	//
 	create: function(req, res) {
-		var params = req.params.all();
+	    var params = req.params.all();
+	    delete params.email_confirm;
+	    delete params.password_confirm;
 
-		Supervisor.create(params).exec(function (err, created) {
-			if (err) {
-				console.log(err);
-				return res.json(500, {error: 'User not created'});				
-			}
-			if (created) {
-				// Send email confirmation
-				console.log("sending mail to user" );
-				created.sendMail();
-				return res.json({user: created, token: sailsTokenAuth.issueToken(created.id)});
-			}
-		});
+	    Supervisor.create(params).exec(function (err, created) {
+		if (err) {
+		    console.log(err);
+		    return res.json(500, {error: 'User not created'});				
+		}
+		if (created) {
+		    // TODO: Send email confirmation
+		    // created.sendMail();
+		    return res.json({
+			user: created, 
+			token: sailsTokenAuth.issueToken(created.id)});		
+		} else {
+		    return res.json(500, {error: 'User not created'});	
+		}
+	    });
 	},
 
 	//

sails/src/api/models/Supervisor.js

@@ -186,32 +186,33 @@ module.exports = {
   //
   beforeCreate: function(attrs, next) {
 
-    //
-    // Check that user does not exist
-    // NOTE: This is not needed as uniqueness is granted by DB 
-    //
-    Supervisor.findByEmail(attrs.email).exec(function(err, users) {
-      if (err)
-        return next(err);
-      if (users.length > 0)
-        return next(new Error('User exists'));
-    });
-
-    //
-    // Encrypt password before insertion
-    //
-    var bcrypt = require('bcrypt-nodejs');
+      // We have to encryption AFTER checking user does not exist
+      // so... we use async.series to ensure task completion
 
-    bcrypt.genSalt(10, function(err, salt) {
-      if (err) 
-        return next(err);
-      bcrypt.hash(attrs.password, salt,  null, function(err, hash) {
-        if (err)
-          return next(err);
-        attrs.password = hash;
-        next();
-      });
-    });
+      async.series([
+	  function(cb) { // check email is new
+	      Supervisor.findByEmail(attrs.email).exec(function(err, users) {
+		  if (err) return cb(err);
+		  if (users.length > 0)
+		      return cb(new Error('User exists'));
+		  cb();
+	      });
+	  },
+	  function(cb) { // encrypt password
+	      var bcrypt = require('bcrypt-nodejs');
+	      bcrypt.genSalt(10, function(err, salt) {
+		  if (err) return cb(err);
+		  bcrypt.hash(attrs.password, salt,  null, function(err, hash) {
+		      if (err) return cb(err);
+		      attrs.password = hash;
+		      cb();
+		  });
+	      });
+	  }
+      ], function(err) {
+	  if (err) return next(err);
+	  next();
+      });      
   },
 
    //
@@ -220,37 +221,45 @@ module.exports = {
   //
   beforeUpdate: function(attrs, next) {
 
-    //
-    // Check that user email does not exist
-    //
-    if(attrs.email){
-      Supervisor.findByEmail(attrs.email).exec(function(err, users) {
-        if (err)
-          return next(err);
-        if (users.length > 0)
-          return next(new Error('User email already exists'));
-      });
-    }
-
-    //
-    // Encrypt password before insertion
-    //
-    if(attrs.password){
-      var bcrypt = require('bcrypt-nodejs');
-
-      bcrypt.genSalt(10, function(err, salt) {
-        if (err) 
-          return next(err);
-        bcrypt.hash(attrs.password, salt,  null, function(err, hash) {
-          if (err)
-            return next(err);
-          attrs.password = hash;
-          next();
-        });
-      });
-    }else{
-      next();
-    }
+      async.series([
+	  function(cb) {
+	      //
+	      // Check that user email does not exist
+	      //
+	      if(attrs.email){
+		  Supervisor.findByEmail(attrs.email).exec(function(err, users) {
+		      if (err)
+			  return cb(err);
+		      if (users.length > 0)
+			  return cb(new Error('User email already exists'));
+		      cb();
+		  });
+	      } else {
+		  return cb(new Error('No email in user attributes'));
+	      }
+	  },
+	  function(cb) {
+	      //
+	      // Encrypt password before insertion
+	      //
+	      if(attrs.password){
+		  var bcrypt = require('bcrypt-nodejs');
+		  
+		  bcrypt.genSalt(10, function(err, salt) {
+		      if (err) return cb(err);
+		      bcrypt.hash(attrs.password, salt,  null, function(err, hash) {
+			  if (err) return cb(err);
+			  attrs.password = hash;
+			  cb();
+		      });
+		  });
+	      }else{
+		  cb();
+	      }
+	  }], function(err) {
+	      if (err) return next(err);
+	      next();
+	  });
   },
 
   //

sails/src/assets/app/modules/login/controllers/signin.js

@@ -21,7 +21,7 @@ dashboardControllers.controller('SignInCtrl', function SignInCtrl($scope, $http,
     lang: 'es'
   };
 
-  reCAPTCHA.setPublicKey('6LdkZwMTAAAAANDR_7_y9_ifEve1gLPcgneM_50o');
+  reCAPTCHA.setPublicKey('6LdLjh0TAAAAANblo_KUGNnmRZuIetOkdjdhj1b6');
 
 /* NOT NECESSARY 
   // Array of key terms to translate 
@@ -84,8 +84,8 @@ dashboardControllers.controller('SignInCtrl', function SignInCtrl($scope, $http,
       $scope.alert = "alert-danger";
       $scope.message = "user_exists";
 
-      console.log("Error from API: " + data.error);
+      console.log("Error from API: " + status);
     });
 
   };
-});
\ No newline at end of file
+});

sails/src/assets/app/modules/login/views/signin.html

@@ -102,4 +102,4 @@
 </div>
 <!-- Fin de container -->
 
-    <footer-translate></footer-translate>
\ No newline at end of file
+    <footer-translate></footer-translate>