perf(DeleteUser): cambiadas funciones de boolean a void

parent aace47e7
...@@ -2,6 +2,6 @@ package com.example.apprecetas.user.application; ...@@ -2,6 +2,6 @@ package com.example.apprecetas.user.application;
public interface DeleteUserUseCase { public interface DeleteUserUseCase {
boolean deleteById(Long id); void deleteById(Long id);
} }
...@@ -3,6 +3,7 @@ package com.example.apprecetas.user.application.impl; ...@@ -3,6 +3,7 @@ package com.example.apprecetas.user.application.impl;
import com.example.apprecetas.exceptions.EntityNotFoundException; import com.example.apprecetas.exceptions.EntityNotFoundException;
import com.example.apprecetas.user.application.DeleteUserUseCase; import com.example.apprecetas.user.application.DeleteUserUseCase;
import com.example.apprecetas.user.domain.repository.DeleteUserRepository; import com.example.apprecetas.user.domain.repository.DeleteUserRepository;
import com.example.apprecetas.user.domain.repository.ReadUserRepository;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
...@@ -10,13 +11,14 @@ import org.springframework.stereotype.Service; ...@@ -10,13 +11,14 @@ import org.springframework.stereotype.Service;
@RequiredArgsConstructor @RequiredArgsConstructor
public class DeleteUserUseCaseImpl implements DeleteUserUseCase { public class DeleteUserUseCaseImpl implements DeleteUserUseCase {
private final DeleteUserRepository repository; private final DeleteUserRepository deleteUserRepository;
private final ReadUserRepository readUserRepository;
@Override @Override
public boolean deleteById(Long id) { public void deleteById(Long id) {
boolean isDeleted = repository.deleteById(id); readUserRepository.readById(id)
if (!isDeleted) .orElseThrow(() -> new EntityNotFoundException("El usuario con id " + id + " no existe."));
throw new EntityNotFoundException("Usuario con id " + id + " no encontrado"); deleteUserRepository.deleteById(id);
return isDeleted;
} }
} }
...@@ -2,6 +2,6 @@ package com.example.apprecetas.user.domain.repository; ...@@ -2,6 +2,6 @@ package com.example.apprecetas.user.domain.repository;
public interface DeleteUserRepository { public interface DeleteUserRepository {
boolean deleteById(Long id); void deleteById(Long id);
} }
...@@ -18,10 +18,8 @@ public class DeleteUserController { ...@@ -18,10 +18,8 @@ public class DeleteUserController {
@DeleteMapping("/{id}") @DeleteMapping("/{id}")
public ResponseEntity<String> deleteById(@PathVariable Long id) { public ResponseEntity<String> deleteById(@PathVariable Long id) {
boolean isDeleted = service.deleteById(id); service.deleteById(id);
if(isDeleted)
return ResponseEntity.ok().body("Usuario con id " + id + " eliminado correctamente"); return ResponseEntity.ok().body("Usuario con id " + id + " eliminado correctamente");
return ResponseEntity.notFound().build();
} }
} }
...@@ -12,12 +12,7 @@ public class DeleteUserRepositoryImpl implements DeleteUserRepository { ...@@ -12,12 +12,7 @@ public class DeleteUserRepositoryImpl implements DeleteUserRepository {
private final UserRepositoryJpa repositoryJpa; private final UserRepositoryJpa repositoryJpa;
@Override @Override
public boolean deleteById(Long id) { public void deleteById(Long id) {
boolean isDeleted = false;
if(repositoryJpa.existsById(id)) {
repositoryJpa.deleteById(id); repositoryJpa.deleteById(id);
isDeleted = true;
}
return isDeleted;
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment