Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
Alba María Álvarez
/
AppRecetas
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
651b00bb
authored
May 29, 2025
by
Alba María Álvarez
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
perf(DeleteUser): cambiadas funciones de boolean a void
parent
aace47e7
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
12 additions
and
17 deletions
src/main/java/com/example/apprecetas/user/application/DeleteUserUseCase.java
src/main/java/com/example/apprecetas/user/application/impl/DeleteUserUseCaseImpl.java
src/main/java/com/example/apprecetas/user/domain/repository/DeleteUserRepository.java
src/main/java/com/example/apprecetas/user/infrastructure/controller/DeleteUserController.java
src/main/java/com/example/apprecetas/user/infrastructure/repository/impl/DeleteUserRepositoryImpl.java
src/main/java/com/example/apprecetas/user/application/DeleteUserUseCase.java
View file @
651b00bb
...
@@ -2,6 +2,6 @@ package com.example.apprecetas.user.application;
...
@@ -2,6 +2,6 @@ package com.example.apprecetas.user.application;
public
interface
DeleteUserUseCase
{
public
interface
DeleteUserUseCase
{
boolean
deleteById
(
Long
id
);
void
deleteById
(
Long
id
);
}
}
src/main/java/com/example/apprecetas/user/application/impl/DeleteUserUseCaseImpl.java
View file @
651b00bb
...
@@ -3,6 +3,7 @@ package com.example.apprecetas.user.application.impl;
...
@@ -3,6 +3,7 @@ package com.example.apprecetas.user.application.impl;
import
com.example.apprecetas.exceptions.EntityNotFoundException
;
import
com.example.apprecetas.exceptions.EntityNotFoundException
;
import
com.example.apprecetas.user.application.DeleteUserUseCase
;
import
com.example.apprecetas.user.application.DeleteUserUseCase
;
import
com.example.apprecetas.user.domain.repository.DeleteUserRepository
;
import
com.example.apprecetas.user.domain.repository.DeleteUserRepository
;
import
com.example.apprecetas.user.domain.repository.ReadUserRepository
;
import
lombok.RequiredArgsConstructor
;
import
lombok.RequiredArgsConstructor
;
import
org.springframework.stereotype.Service
;
import
org.springframework.stereotype.Service
;
...
@@ -10,13 +11,14 @@ import org.springframework.stereotype.Service;
...
@@ -10,13 +11,14 @@ import org.springframework.stereotype.Service;
@RequiredArgsConstructor
@RequiredArgsConstructor
public
class
DeleteUserUseCaseImpl
implements
DeleteUserUseCase
{
public
class
DeleteUserUseCaseImpl
implements
DeleteUserUseCase
{
private
final
DeleteUserRepository
repository
;
private
final
DeleteUserRepository
deleteUserRepository
;
private
final
ReadUserRepository
readUserRepository
;
@Override
@Override
public
boolean
deleteById
(
Long
id
)
{
public
void
deleteById
(
Long
id
)
{
boolean
isDeleted
=
repository
.
deleteById
(
id
);
readUserRepository
.
readById
(
id
)
if
(!
isDeleted
)
.
orElseThrow
(()
->
new
EntityNotFoundException
(
"El usuario con id "
+
id
+
" no existe."
));
throw
new
EntityNotFoundException
(
"Usuario con id "
+
id
+
" no encontrado"
);
deleteUserRepository
.
deleteById
(
id
);
return
isDeleted
;
}
}
}
}
src/main/java/com/example/apprecetas/user/domain/repository/DeleteUserRepository.java
View file @
651b00bb
...
@@ -2,6 +2,6 @@ package com.example.apprecetas.user.domain.repository;
...
@@ -2,6 +2,6 @@ package com.example.apprecetas.user.domain.repository;
public
interface
DeleteUserRepository
{
public
interface
DeleteUserRepository
{
boolean
deleteById
(
Long
id
);
void
deleteById
(
Long
id
);
}
}
src/main/java/com/example/apprecetas/user/infrastructure/controller/DeleteUserController.java
View file @
651b00bb
...
@@ -18,10 +18,8 @@ public class DeleteUserController {
...
@@ -18,10 +18,8 @@ public class DeleteUserController {
@DeleteMapping
(
"/{id}"
)
@DeleteMapping
(
"/{id}"
)
public
ResponseEntity
<
String
>
deleteById
(
@PathVariable
Long
id
)
{
public
ResponseEntity
<
String
>
deleteById
(
@PathVariable
Long
id
)
{
boolean
isDeleted
=
service
.
deleteById
(
id
);
service
.
deleteById
(
id
);
if
(
isDeleted
)
return
ResponseEntity
.
ok
().
body
(
"Usuario con id "
+
id
+
" eliminado correctamente"
);
return
ResponseEntity
.
ok
().
body
(
"Usuario con id "
+
id
+
" eliminado correctamente"
);
return
ResponseEntity
.
notFound
().
build
();
}
}
}
}
src/main/java/com/example/apprecetas/user/infrastructure/repository/impl/DeleteUserRepositoryImpl.java
View file @
651b00bb
...
@@ -12,12 +12,7 @@ public class DeleteUserRepositoryImpl implements DeleteUserRepository {
...
@@ -12,12 +12,7 @@ public class DeleteUserRepositoryImpl implements DeleteUserRepository {
private
final
UserRepositoryJpa
repositoryJpa
;
private
final
UserRepositoryJpa
repositoryJpa
;
@Override
@Override
public
boolean
deleteById
(
Long
id
)
{
public
void
deleteById
(
Long
id
)
{
boolean
isDeleted
=
false
;
if
(
repositoryJpa
.
existsById
(
id
))
{
repositoryJpa
.
deleteById
(
id
);
repositoryJpa
.
deleteById
(
id
);
isDeleted
=
true
;
}
return
isDeleted
;
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment